How does our Merge Policy work?

[berinhard]

Hey @anapaulagomes and @amureki I though about creating this page just to document what are our policies to merge new PRs. I think this way contributors will be able to know if something still needs review or if it's a "forgotten" PR etc. Let me know if you agree or change/add/remove something.

So, how does our it work?

[berinhard]

PRs can only be merged if:

Both changelog and tests builds in CI must be passing;
The PR must have the required minimum of approvals;

If both requisites are fulfilled, the PR can be merged by any maintainer.

Minimum Approvals Policy

There are 2 possible creators of PRs, contributors and maintainers. So, I think we can treat each one differently.

contributors' PR: must always have at least 2 reviews and approvals from the maintainers;
maintainers' PR: must have at least 2 reviews and approvals from the maintainers. BUT, if there's only 1 approval and it passed more than 7 days from it, the 2 maintainers (PR creator and reviewer) can decide by themselves if the PR can be merged. If so, they shall notify the other maintainers in a comment after the merge.

[amureki]

Sounds good, we definitely can try it out and see how it will go! Thanks for adding this proposal! 👍

[anapaulagomes]

Seems good to me, @berinhard. Shall we add something about the release process?

[berinhard]

Sure @anapaulagomes! I've never thought about that. Honestly, there release policy always have been "whenever I have time", but now we definitely can change that. Feel free to open a discussion about that.