Fix Recipe Import Bug from Non-Installed-App Module #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add unit tests for happy and sad path
berinhard
approved these changes
Jun 7, 2021
There was a problem hiding this comment.
This PR looks great! Thanks for you contribution @timjklein36 <3
|
After @anapaulagomes or @amureki reviews, we can merge this and release a new version with bugfix. |
amureki
approved these changes
Jun 13, 2021
amureki
pushed a commit
that referenced
this pull request
Jun 13, 2021
- Fixed a bug (introduced in [1.2.1](https://pypi.org/project/model-bakery/1.2.1/)) that was breaking imports of recipes from non-installed-app modules [PR #201](#201) - Dependencies updates
|
We released this fix in https://pypi.org/project/model-bakery/1.3.2/ |
|
Hey @timjklein36 hope you're fine! As you're becoming a regular contributor, we wondered if you're not interested on joining the maintainers team. We'd be happy to have you onboard so you can feel more invited and free to contribute to the project. If you're up to it, please, ping me or @amureki on Twitter: |
|
Thank you @timjklein36 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192.
Using @Arussil's suggestion from the same referenced issue, added unit tests to cover the bug case and existing behavior.