Clippy in Regressions.

[YoshikiTakashima]

Description of changes:

No change to kani behavior. Added clippy linter to regression suite.

Resolved issues:

Lack of clippy lint checking in kani regression script. #1373 will stay open to track actual clippy errors.

Call-outs:

The current setup addresses the following clippy regressions.

• New clippy error/warning in a library that did not have them (thus not ignored)
• New class of clippy warnings/errors by code change

Testing:

• How is this change tested? Run the regression script

• Is this a refactor change?

Checklist

• Each commit message has a non-empty body, explaining why the change was made
• Methods or procedures are documented
• Regression or unit tests are included, or existing tests cover the modified code
• My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

[giltho]

I'm not sure how clippy gets configured for a whole workspace, so I'm not sure if the first comment has a solution, the second one should probably be "fixed" before merging

[celinval]

Thanks for doing this. I have 2 questions:

1. Is there a reason why you preferred .cargo/config.toml instead of clippy.toml.
2. How long does cargo clippy takes? I was wondering if we should enable this in our regression.

[YoshikiTakashima]

@celinval

1. Is there a reason why you preferred .cargo/config.toml instead of clippy.toml.

I don't think that is possible, and keeping it so seems to be the stance from clippy devs: rust-lang/rust-clippy#1313 (comment). The idea behind it seems to be that you would control all lints at once, not just clippy lints.

2. How long does cargo clippy takes? I was wondering if we should enable this in our regression.

It takes no longer than 2 compiles with cargo build --workspace. This is the first job to finish.

[giltho]

LGTM ✅

[YoshikiTakashima]

Not sure how big the "code owner" set is but it still saids it waiting for review. @tedinski / @celinval