Add --mir-linker flag and wire it up to the compiler
#1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the MIR linker hasn't been hooked up yet, the compiler will fail if this option is selected as shown by the new tests.
celinval
changed the title
--mir-linker and wire it up to the compiler--mir-linker flag and wire it up to the compiler
tedinski
reviewed
Sep 12, 2022
| rand = "0.8.4" | ||
|
|
||
| [package.metadata.kani] | ||
| flags = { mir-linker=true, enable-unstable=true } |
There was a problem hiding this comment.
No expected file for this one?
There was a problem hiding this comment.
Ooops. Thanks for the call out.
kani-driver/src/call_cargo.rs
Outdated
| .env("RUSTFLAGS", "--kani-flags") | ||
| .env("KANIFLAGS", flag_env); | ||
| // Only joing them at the end. All kani flags must come first. | ||
| kani_args.append(&mut rustc_args); |
There was a problem hiding this comment.
&mut? oh, wait this says append not extend. IMO extend is cleaner because it avoids needing the mut
There was a problem hiding this comment.
Sure. I'll use extend_from_slice().
tedinski
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change adds the
--mir-linkeroption tokani-driverand--reachability=[none | legacy | harnesses]to the compiler. I also changedcargo kanito invokecargo rustcinstead ofcargo [build | tests]so the reachability flag is passed at the right moment.Resolved issues:
Resolves #1617
Related RFC:
#1600
Call-outs:
cargo rustc -- --reachability=harnesseswill inject the argument--reachability=harnessin the middle of the compiler flags. Thus, it has to be extracted from rustc args. :(Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.