Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cbmc version #2512

Merged
merged 4 commits into from Jun 9, 2023
Merged

Update Cbmc version #2512

merged 4 commits into from Jun 9, 2023

Conversation

celinval
Copy link
Contributor

@celinval celinval commented Jun 9, 2023

Description of changes:

Update Kani to use CBMC 5.85.0

Resolved issues:

Resolves #ISSUE-NUMBER

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested?

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@celinval celinval requested a review from a team as a code owner June 9, 2023 02:22
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The CBMC homebrew package typically takes an extra day, so the macos regressions will fail till then.

Do you want to marks this as a resolver for #2457 (or at least say "Towards #2457")?

@celinval
Copy link
Contributor Author

celinval commented Jun 9, 2023

Thanks. The CBMC homebrew package typically takes an extra day, so the macos regressions will fail till then.

Do you want to marks this as a resolver for #2457 (or at least say "Towards #2457")?

Sure... have you tried running everything together? I can try on my side if you haven't.

@celinval celinval linked an issue Jun 9, 2023 that may be closed by this pull request
@zhassan-aws
Copy link
Contributor

Sure... have you tried running everything together? I can try on my side if you haven't.

I haven't.

@zhassan-aws
Copy link
Contributor

Just tried this right now (upgrading to CBMC 5.85.0 and upgrading the toolchain to 2023-04-30), and I confirmed that the memory blow-up no longer occurs with the two btreeset perf tests, so #2457 can be marked fixed.

@celinval celinval merged commit 74839c7 into model-checking:main Jun 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow down and higher memory usage with 2023-04-30 rust toolchain
2 participants