Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for stubbing out foreign functions #2658

Merged
merged 7 commits into from
Aug 8, 2023
Merged

Support for stubbing out foreign functions #2658

merged 7 commits into from
Aug 8, 2023

Conversation

feliperodri
Copy link
Contributor

@feliperodri feliperodri commented Aug 3, 2023 •
edited

Description of changes:

Support for stubbing out foreign functions.

Resolved issues:

Resolves #2587.

Call-outs:

N/A.

Testing:

  • How is this change tested? Regression tests.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@feliperodri feliperodri self-assigned this Aug 3, 2023
@feliperodri feliperodri force-pushed the extern-c-stubbing branch 2 times, most recently from 077ef36 to fbc7abd Compare August 3, 2023 20:24
@feliperodri feliperodri marked this pull request as ready for review August 3, 2023 22:01
@feliperodri feliperodri requested a review from a team as a code owner August 3, 2023 22:01
JustusAdam
JustusAdam suggested changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@JustusAdam JustusAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a test case for the use of function pointers ad make sure it is handled, irrespective of whether we want to allow use of function pointers or not.

tests/kani/Stubbing/extern_c.rs Outdated Show resolved Hide resolved
kani-compiler/src/kani_middle/provide.rs Show resolved Hide resolved
kani-compiler/src/kani_middle/stubbing/transform.rs Outdated Show resolved Hide resolved
@feliperodri feliperodri changed the title Support for stubbing out extern functions Support for stubbing out foreign functions Aug 4, 2023
JustusAdam
JustusAdam reviewed Aug 4, 2023
View reviewed changes
kani-compiler/src/kani_middle/stubbing/transform.rs Outdated Show resolved Hide resolved
tests/kani/Stubbing/extern_c.rs Outdated Show resolved Hide resolved
kani-compiler/src/kani_middle/stubbing/transform.rs Outdated Show resolved Hide resolved
kani-compiler/src/kani_middle/stubbing/transform.rs Outdated Show resolved Hide resolved
@feliperodri feliperodri enabled auto-merge (squash) August 7, 2023 22:26
@feliperodri feliperodri mentioned this pull request Aug 8, 2023
Open
celinval
celinval reviewed Aug 8, 2023
View reviewed changes
tests/kani/Stubbing/extern_c.rs Outdated Show resolved Hide resolved
tests/kani/Stubbing/extern_c.rs Outdated Show resolved Hide resolved
@feliperodri
Support for stubbing out extern functions
1d88453 
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri
Only replace call to foreign functions
d0c0e31 
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri
Add test case with function pointer
78f77ff 
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri
Add function-pointer test case without generic type
3cde065 
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri
Only store local declarations in ForeignFunctionTransformer
420905d 
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri feliperodri enabled auto-merge (squash) August 8, 2023 18:23
@feliperodri
Breakdown the regression into multiple harnesses
2d84403 
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri
Comply with toolchain update
9be2b44 
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri feliperodri merged commit 6a151f9 into model-checking:main Aug 8, 2023
12 checks passed
@feliperodri feliperodri deleted the extern-c-stubbing branch August 8, 2023 19:24
celinval
celinval reviewed Aug 8, 2023
View reviewed changes
kani-compiler/src/kani_middle/stubbing/transform.rs
pub fn transform_foreign_functions<'tcx>(tcx: TyCtxt<'tcx>, body: &mut Body<'tcx>) {
if let Some(stub_map) = get_stub_mapping(tcx) {
let mut visitor =
ForeignFunctionTransformer { tcx, local_decls: body.clone().local_decls, stub_map };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should do body.local_decls.clone() instead.

@roypat roypat mentioned this pull request Aug 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celinval celinval celinval left review comments

@JustusAdam JustusAdam JustusAdam approved these changes

Assignees

@feliperodri feliperodri

Labels
None yet
Projects
No open projects
Kani 2023-08-22
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stub of extern functions including C-FFI
3 participants
@feliperodri @JustusAdam @celinval