Add support to simd_bitmask
#2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a sequential model of `simd_bitmask` and create a transformation pass that replace calls to the simd_bitmask intrinsic by the new model. We will only replace those usages that we can safely get information about the simd representation.
zhassan-aws
reviewed
Aug 14, 2023
|
Thanks for implementing this, @celinval! |
celinval
commented
Aug 14, 2023
Conflicts:
library/kani/src/lib.rs
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
celinval
force-pushed
the
issue-2131-bitmask
branch
from
4b6858a
to
724d163
Compare
|
Sorry, I merged before pulling from my remote branch, so I force pushed over 4b6858a. |
zhassan-aws
approved these changes
Aug 16, 2023
JustusAdam
reviewed
Aug 17, 2023
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Create a sequential model of
simd_bitmaskand create a transformation pass that replace calls to the simd_bitmask intrinsic by the new model.We will only replace those usages that we can safely get information about the simd representation.
Resolved issues:
Resolves #2131
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
--build-stdflag which is needed to build the standard library. Once that gets merged into main, all the related changes should go away.Testing:
How is this change tested? new tests
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.