Add method to assert a pointer is valid #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
force-pushed
the
issue-2690-ptr-access
branch
from
bb76434
to
185c6e6
Compare
celinval
force-pushed
the
issue-2690-ptr-access
branch
from
8af7b24
to
83dfcc6
Compare
zhassan-aws
reviewed
Mar 8, 2024
There was a problem hiding this comment.
Awesome, thanks @celinval!
Can we add at least one expected test so that we can match against the descriptions of the new pointer checks (Dangling pointer, non-null pointer, valid pointer, etc.).
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
zhassan-aws
reviewed
Mar 8, 2024
zhassan-aws
approved these changes
Mar 8, 2024
Would you like me to document that this signature is temporary? The method is marked as unstable too. |
This should be sufficient. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new method will assert that a pointer isn't null, and that its is valid for access of a given type.
I'm creating this as a draft for now as I'm still adding more tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.