Contracts: History Expressions via "old" monad #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feliperodri
requested changes
Jun 17, 2024
|
@JustusAdam could you give another review? |
Co-authored-by: Felipe R. Monteiro <rms.felipe@gmail.com>
Co-authored-by: Felipe R. Monteiro <rms.felipe@gmail.com>
JustusAdam
approved these changes
Jun 17, 2024
celinval
previously requested changes
Jun 17, 2024
celinval
reviewed
Jun 18, 2024
There was a problem hiding this comment.
Thanks for adding the ui tests. I think we need to work on these error messages though. I'm OK with making it a follow up PR, but I'll leave it up to you and @feliperodri.
feliperodri
approved these changes
Jun 18, 2024
tests/expected/function-contract/history/ui/noncopy_ignore.expected
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for History Expressions. This allows an ensures clause to evaluate expressions before the function runs, bing them to anonymous variables and use them after calculating the result to be able to compare to the state before the function evaluation.
Resolves #2803
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.