rockchip resize flowunit code #293

fujl · 2022-10-10T11:15:23Z

rockchip resize flowunit code

pymumu · 2022-10-11T01:43:50Z

src/drivers/devices/rockchip/flowunit/resize/CMakeLists.txt

+include_directories(${LIBMODELBOX_BASE_INCLUDE})
+include_directories(${LIBMODELBOX_DEVICE_ROCKCHIP_INCLUDE})
+include_directories(${RKMPP_INCLUDE_DIR})
+include_directories(${RKRGA_INCLUDE_DIR})


RKRGA_INCLUDE_DIR这两个变量哪里获取的？

pymumu · 2022-10-11T01:44:30Z

src/drivers/devices/rockchip/flowunit/resize/resize_flowunit.cc

@@ -0,0 +1,139 @@
+/*


License使用开源的

pymumu · 2022-10-11T01:45:01Z

src/drivers/devices/rockchip/flowunit/resize/resize_flowunit.cc

+
+modelbox::Status ResizeFlowUnit::Open(
+    const std::shared_ptr<modelbox::Configuration> &opts) {
+  dest_width_ = opts->GetUint32("width", 0);


不用这个，直接用下面那个就可以了

pymumu · 2022-10-11T01:46:01Z

src/drivers/devices/rockchip/flowunit/resize/resize_flowunit.cc

+    in_image->Get("pix_fmt", pix_fmt);
+    rga_fmt = modelbox::GetRGAFormat(pix_fmt);
+    if (rga_fmt == RK_FORMAT_UNKNOWN) {
+      continue;


这里是不是应该返回错误？

pymumu · 2022-10-11T01:46:45Z

src/drivers/devices/rockchip/flowunit/resize/CMakeLists.txt

@@ -0,0 +1,64 @@
+# Copyright (c) Huawei Technologies Co., Ltd. 2022. All rights reserved.


缺少测试用例。

CarlosLeeGit · 2022-10-11T07:22:13Z

src/drivers/devices/rockchip/flowunit/resize/resize_flowunit.cc

+  }
+
+  if (dest_width_ < MIN_SIZE || dest_height_ < MIN_SIZE) {
+    MBLOG_ERROR << "Dest width or dest height must larger than 32, dest_width:"


应该提示大于等于great equal than吧。

pansgg · 2022-10-12T01:23:40Z

src/drivers/devices/rockchip/flowunit/resize/resize_flowunit.h

+
+constexpr const char *FLOWUNIT_TYPE = "rockchip";
+constexpr const char *FLOWUNIT_NAME = "resize";
+constexpr const char *FLOWUNIT_DESC =


rk的输入输出数据的buffer和meta是否和cpu完全一样？有没有额外限制？限制加入描述

一样的，已经补充描述

pansgg · 2022-10-12T01:24:25Z

src/drivers/devices/rockchip/flowunit/resize/resize_flowunit.h

+constexpr const char *FLOWUNIT_NAME = "resize";
+constexpr const char *FLOWUNIT_DESC =
+    "A resize flowunit on RockChip, one image as input, one resize image as "
+    "output";


参考其他resize 增加输入输出meta 说明

pansgg · 2022-10-12T01:33:54Z

src/drivers/devices/rockchip/flowunit/resize/resize_flowunit.cc

+    auto out_image = modelbox::CreateEmptyMppImg(dest_width_, dest_height_,
+                                                 rga_fmt, device, out_buf);
+    if (out_image == nullptr) {
+      continue;


增加日志

pansgg · 2022-10-12T01:37:42Z

src/drivers/devices/rockchip/flowunit/resize/resize_flowunit.cc

+  rk_resize_desc.SetFlowUnitName(FLOWUNIT_NAME);
+  rk_resize_desc.SetFlowUnitGroupType("Image");
+  rk_resize_desc.AddFlowUnitInput({IN_IMG, modelbox::DEVICE_TYPE});
+  rk_resize_desc.AddFlowUnitOutput({OUT_IMG, modelbox::DEVICE_TYPE});


AddFlowUnitInput
AddFlowUnitOutput
按照新接口写，不用设置 modelbox::DEVICE_TYPE，默认和功能单元一直

CarlosLeeGit · 2022-10-19T03:34:37Z

src/drivers/devices/rockchip/flowunit/resize/resize_flowunit_test.cc

+  ASSERT_EQ(output_buffer_list->Size(), 1);
+  auto output_buffer = output_buffer_list->At(0);
+  ASSERT_EQ(output_buffer->GetBytes(), 112 * 110 * 3 / 2);
+  cv::Mat yuv_out_img(110 * 3 / 2, 112, CV_8UC1);


输出数据没看到对比的地方

pymumu · 2022-10-26T12:22:29Z

src/drivers/devices/rockchip/flowunit/resize/resize_flowunit_test.cc

+
+ protected:
+  void SetUp() override {
+    // Test rockchip runtime


没有RKNPU的情况，应该跳过测试用例。

已修改为初始化jpge_decode失败跳过测试用例

pymumu · 2022-10-26T12:22:58Z

src/drivers/devices/rockchip/flowunit/resize/resize_flowunit.cc

+  rk_resize_desc.AddFlowUnitInput({IN_IMG});
+  rk_resize_desc.AddFlowUnitOutput({OUT_IMG});
+  rk_resize_desc.SetFlowType(modelbox::NORMAL);
+  rk_resize_desc.SetInputContiguous(false);


这个设置移动到device里面

pymumu reviewed Oct 11, 2022

View reviewed changes

fujl force-pushed the rkresize branch 2 times, most recently from 4b2308b to 51216c9 Compare October 11, 2022 02:05

CarlosLeeGit reviewed Oct 11, 2022

View reviewed changes

pansgg reviewed Oct 12, 2022

View reviewed changes

fujl force-pushed the rkresize branch 6 times, most recently from 0b841c6 to e3d71a6 Compare October 17, 2022 06:30

CarlosLeeGit reviewed Oct 19, 2022

View reviewed changes

fujl force-pushed the rkresize branch 6 times, most recently from 9fd8e27 to 3606289 Compare October 26, 2022 08:27

pymumu reviewed Oct 26, 2022

View reviewed changes

rockchip resize flowunit code

6798f74

fujl force-pushed the rkresize branch from 3606289 to 6798f74 Compare October 27, 2022 01:46

pymumu approved these changes Oct 27, 2022

View reviewed changes

pansgg approved these changes Oct 28, 2022

View reviewed changes

pymumu merged commit c80e20a into modelbox-ai:main Oct 28, 2022

pymumu mentioned this pull request Oct 28, 2022

这个设置移动到device里面 #305

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rockchip resize flowunit code #293

rockchip resize flowunit code #293

fujl commented Oct 10, 2022

pymumu Oct 11, 2022

fujl Oct 11, 2022

pymumu Oct 11, 2022

fujl Oct 11, 2022

pymumu Oct 11, 2022

fujl Oct 26, 2022

pymumu Oct 11, 2022

fujl Oct 17, 2022

pymumu Oct 11, 2022

fujl Oct 17, 2022

CarlosLeeGit Oct 11, 2022

fujl Oct 17, 2022

pansgg Oct 12, 2022

fujl Oct 17, 2022

pansgg Oct 12, 2022

fujl Oct 17, 2022

pansgg Oct 12, 2022

fujl Oct 17, 2022

pansgg Oct 12, 2022

fujl Oct 17, 2022

CarlosLeeGit Oct 19, 2022

fujl Oct 20, 2022

pymumu Oct 26, 2022

fujl Oct 27, 2022

pymumu Oct 26, 2022

		@@ -0,0 +1,64 @@
		# Copyright (c) Huawei Technologies Co., Ltd. 2022. All rights reserved.

rockchip resize flowunit code #293

rockchip resize flowunit code #293

Conversation

fujl commented Oct 10, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment