Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to MSL 4.0.0 #45

Closed
casella opened this issue Sep 23, 2021 · 4 comments
Closed

Upgrade to MSL 4.0.0 #45

casella opened this issue Sep 23, 2021 · 4 comments
Assignees
Milestone

Comments

@casella
Copy link
Collaborator

casella commented Sep 23, 2021

I just had a discussion with @bilderbuchi and @imkelisa at the Modelica Conference. They have already moved all of their libraries to MSL 4.0.0, so it would be nice to also have ExternalMedia there.

It also doesn't make much sense to develop new funcionaltiy on the MSL 3.2.3 branch.

I would propose that we run the MSL 4.0.0 conversion script and release a version 4.0.0 right away.

We can then have some bugfix versions 3.3.x for critical bugs, but otherwise continue under MSL 4.0.0

@jowr, are you fine with that?

@casella casella self-assigned this Sep 23, 2021
@bilderbuchi
Copy link
Collaborator

Just to clarify, I was mainly present because of/interested in OpenModelica compatibility; luckily I am not encumbered by many pre-existing libraries/models. :-)

@imkelisa
Copy link

I did a quick test on converting the library (master branch) to MSL 4.0.0 with Dymola 2022.

  • several incompatible units in test models (time is multiplied e.g. with a pressure to have a varying input)
    -in ExternalMedia.Media.BaseClasses.ExternalTwoPhaseMedium FluidConstants is replaceable, in MSL Media 2 phase mediums use an externally defined record for the fluid constants

Not simulating:

  • ExternalMedia.Test.CoolProp.CO2.TestStatesSatSubcritical "T is not a valid number"
  • ExternalMedia.Test.CoolProp.Pentane_hs "Inputs in Brent [143.470000,578.730000] do not bracket the root. Function values are [6916.155129,60536.779546]
    The stack of functions is:
    setState_hs_Unique29
    setState_hs_Unique29(h, 1500.0, 0)" (last model I tested today)

@imkelisa
Copy link

Just a comment for Dymola: One has to set Advanced.RelyOnCompiledFunctions=true; in order to prevent Dymola from trying to recompile the external functions (Default behaviour up to Dymola 2018, has been changed after that). See Chapter 5.5.9 in the manual

@jowr jowr added this to the v4.0.0 milestone Feb 17, 2022
@jowr
Copy link
Collaborator

jowr commented Feb 17, 2022

This was closed in 8e37df8

@jowr jowr closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants