-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trouble running the Compare tool due to locale settings #2
Comments
Problem might be, that the Option tolerance is preset using a string: [Option('t', "tolerance", DefaultValue = "0.002", Required = false, HelpText = "Set the width of the tube at discontinuity in x-direction [Default is 0.002].")]
public string Tolerance { get; set; } Removing the default value should fix the issue. |
Unfortunately that solution is still locale dependent, which in our case causes problems since we use CSV Compare from within our software, i.e. the calls are done from scripts. |
Can you tell me which locale fails and which settings? The code already implemented in csv compare for parsing the value for the tolerance handles "0.002", "0,002" and "2e-3" and should not depent on locale settings; I'm going to check this. The program should of course not be locale dependent; the problem here (I think) was the hard coded string for the default value. Without this hard coded value, the program should correctly parse the tolerance in any of the 3 formattings. |
Ok that is good to hear, then we are on the same page. However the current behaviour that we see with Christian Andersson's (from MA ticket linked above) build of r8061 is strange, it really looks like if it is locale dependent. So sorry to say it but it really seems as if computer locale affects the program. |
…sed exception on systems with "," instead of "." as double separator
I found the issue. It was a bug in the code. I used the commandline option directly and not the parsed object. The default value can stay as it is. I debugged it using swedish locale settings on my computer. |
Nice :) |
from: https://trac.modelica.org/Modelica/ticket/1646
I tried running the Compare tool (r8061) with a simple csv file using the command
This however gives an error
where the problematic part seems to be the tolerance as the below command works fine,
This needs to be fixed so that it works out of the box. Additionally this dependency on the locale makes it difficult to use the Compare tool in other tools.
The text was updated successfully, but these errors were encountered: