Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple inheritance of graphical annotations #1750

Closed
modelica-trac-importer opened this issue Nov 4, 2018 · 5 comments
Closed

multiple inheritance of graphical annotations #1750

modelica-trac-importer opened this issue Nov 4, 2018 · 5 comments
Assignees
Labels
discussion Indicates that there's a discussion; not clear if bug, enhancement, or working as intended

Comments

@modelica-trac-importer
Copy link
Collaborator

Reported by msasena on 22 Jul 2015 20:28 UTC
I couldn't find anything in the specification that describes how to handle components that inherit graphical annotations from multiple classes. Take a simple example:

model A
  extends Icon1;
  extends Icon2;
end A;

What should the icon for model A look like? Should Icon2 be displayed in front of Icon1, or should it be the other way around? Should the order of instantiation matter in any way?


Migrated-From: https://trac.modelica.org/Modelica/ticket/1750

@modelica-trac-importer modelica-trac-importer added the discussion Indicates that there's a discussion; not clear if bug, enhancement, or working as intended label Nov 4, 2018
@modelica-trac-importer
Copy link
Collaborator Author

Modified by beutlich on 2 Mar 2016 10:23 UTC

@modelica-trac-importer
Copy link
Collaborator Author

Comment by hansolsson on 8 Mar 2016 14:09 UTC
Replying to [ticket:1750 msasena]:

I couldn't find anything in the specification that describes how to handle components that inherit graphical annotations from multiple classes. Take a simple example:

model A
  extends Icon1;
  extends Icon2;
end A;

What should the icon for model A look like? Should Icon2 be displayed in front of Icon1, or should it be the other way around? Should the order of instantiation matter in any way?

In Dymola Icon2 is displayed in front of Icon1; similarly as later components are displayed in front of earlier ones.

Unfortunately we have only stated that the objects are ordered - not that this defines the drawing order, but I assume everyone uses the same order or Inductor would have the wrong icon.

(There might also be some other minor issues with the drawing order.)

@modelica-trac-importer
Copy link
Collaborator Author

Comment by hansolsson on 7 Sep 2016 12:01 UTC
This should be clarified in 18.6:

The graphics is specified as an ordered sequence of graphical primitives, which are described below. Contents is drawn according to the order such that later objects can cover earlier ones, and base-class contents drawn according to the order of the extends-clauses.

@modelica-trac-importer modelica-trac-importer added this to the Design91 milestone Nov 4, 2018
@modelica-trac-importer
Copy link
Collaborator Author

Comment by hansolsson on 12 Sep 2016 12:40 UTC
Replying to [comment:3 hansolsson]:

This should be clarified in 18.6:

The graphics is specified as an ordered sequence of graphical primitives, which are described below. Contents is drawn according to the order such that later objects can cover earlier ones, and base-class contents drawn according to the order of the extends-clauses.

Should clarify that base-classes is done first:

The graphics is specified as an ordered sequence of graphical primitives, which are described below. First base-class contents is drawn according to the order of the extends-clauses, and then graphical primitives are drawn according to the order such that later objects can cover earlier ones.

Favor: 9
Against: 0
Rest abstain.

@modelica-trac-importer
Copy link
Collaborator Author

Comment by hansolsson on 23 Sep 2016 13:09 UTC
Resolved in r9490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Indicates that there's a discussion; not clear if bug, enhancement, or working as intended
Projects
None yet
Development

No branches or pull requests