Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed = to := in algorithms #2354

Merged
merged 1 commit into from Aug 23, 2019
Merged

Changed = to := in algorithms #2354

merged 1 commit into from Aug 23, 2019

Conversation

HildingElmqvist
Copy link
Contributor

No description provided.

HansOlsson
HansOlsson reviewed Jun 3, 2019
View reviewed changes
Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are good, but since it is a "new" contributor (in some way) I prefer if we get a signed CLA first.

@GallLeo
Copy link
Collaborator

GallLeo commented Aug 23, 2019

MA Backoffice now filed Hilding's MA CLA, so merging should be fine.

HansOlsson
HansOlsson approved these changes Aug 23, 2019
View reviewed changes
Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only concern was the CLA and that is now in place.

@HansOlsson HansOlsson merged commit c6439d5 into modelica:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansOlsson HansOlsson HansOlsson approved these changes

@GallLeo GallLeo GallLeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HildingElmqvist @GallLeo @HansOlsson