Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find files with trailing whitespace #2361

Merged
merged 2 commits into from Jun 4, 2019

Conversation

sjoelund
Copy link
Member

The CI should fail if we find any LaTeX file with trailing whitespace.

Note: This should not be possible to merge until all whitespace has been removed (which we should not do until #2353 is fixed).

@sjoelund sjoelund force-pushed the check-trailing-whitespace branch 3 times, most recently from 90e8794 to 7594fa0 Compare May 15, 2019 13:04
@sjoelund
Copy link
Member Author

Jenkins (ephermal link; will be broken in the future) now shows the files (and lines) that improperly end with a whitespace. We could possibly also use a pre-commit hook for trimming trailing whitespace automatically.

@beutlich beutlich added the CI Issue that addresses continuous integration label May 29, 2019
@HansOlsson HansOlsson self-requested a review June 4, 2019 09:51
Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but we need to clean up the files first.

Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok now.

The CI should fail if we find any LaTeX file with trailing whitespace.
@sjoelund sjoelund merged commit c559516 into modelica:master Jun 4, 2019
@sjoelund sjoelund deleted the check-trailing-whitespace branch June 4, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issue that addresses continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants