Quoted #2463
Merged
Quoted #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svorkoetter
approved these changes
Dec 6, 2019
svorkoetter
approved these changes
Dec 6, 2019
beutlich
reviewed
Dec 6, 2019
chapters/lexicalstructure.tex
Outdated
Comment on lines
84
to
86
| The single quotes are part of the identifier, i.e., \lstinline!'x'! and \lstinline!x! | ||
| are distinct identifiers, but the redundant escapes (\lstinline!'\?'! and \lstinline!'\"'!) are the same as the corresponding non-escaped | ||
| variants (\lstinline!'?'! and \lstinline!'"'!). A full BNF definition of the Modelica syntax and | ||
| variants (\lstinline!'?'! and \lstinline!'"'!), and outside of Modelica source code the redundant escapes shall not be used. |
There was a problem hiding this comment.
Might be easier to grasp if that long sentence is split in two or three parts.
There was a problem hiding this comment.
Agreed, and I tried to do that.
henrikt-ma
requested changes
Dec 11, 2019
svorkoetter
approved these changes
Dec 12, 2019
henrikt-ma
approved these changes
Dec 13, 2019
jespermattsson
approved these changes
Dec 13, 2019
jespermattsson
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to clarify single-quoted identifiers.
Closes #2408
Since this is a straightforward but non-trivial change, I want that in addition to the review that you vote thumbs up to accept or thumbs down if you don't think it should be accepted.
The poll is running to 2019-12-19.