Settle the top level structure #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this PR is where we are supposed to decide whether to introduce a new keyword such as |
|
Web Meeting: Overloaded operator can bee added to future version if it turns out that they are needed. For now they shall be removed. |
|
Web Meeting:
Shall be rebased on top of the merged grammar [Henrik]. |
Besides being a significant simplification of Flat Modelica semantics, this also removes an important use of nested class definitions in Modelica, since an overloaded operator needs to be defined inside the operator record to which it belongs.
This allows for more clear marking of the removed parts of the grammar.
henrikt-ma
force-pushed
the
MCP/0031+top-level-structure
branch
from
071cad2
to
40dce6b
Compare
|
Rebased. Marking as Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening PR for roadmap item 'Settle the top level structure'.
Note that operator overloading is being removed in the current state. If we want to keep them, we should add production rules specifically for these, so that we avoid reintroducing recursiveness of class-definition.
Before being ready for merge, we should first merge #2465 (and resolve the resulting conflicts).