Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write that model and class are the same #2493

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

HansOlsson
Copy link
Collaborator

Closes #1345
Might discuss at the design meeting.

@HansOlsson HansOlsson added this to the Design101 milestone Feb 13, 2020
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this is the basic fix for #1345.

The change made me wonder, however, if this table is supposed to be of normative or non-normative kind. To me, it looks a bit like a mix of normative statements and more vague statements about intended purpose. If the table is meant to be normative, I find the new wording for model too vague. If the table is meant to be non-normative, I would suggest at least making the intention of the table more clear in the preceding paragraph.

@HansOlsson
Copy link
Collaborator Author

Right, this is the basic fix for #1345.

The change made me wonder, however, if this table is supposed to be of normative or non-normative kind. To me, it looks a bit like a mix of normative statements and more vague statements about intended purpose. If the table is meant to be normative, I find the new wording for model too vague. If the table is meant to be non-normative, I would suggest at least making the intention of the table more clear in the preceding paragraph.

I agree that clearing up that would be clear; but that will need more discussion.

It might also be that it should be a mix, and then we should make that clear, e.g.: Purpose (non-normative) and Restrictions/Enhancements (normative). However, it might also be that the normative-part is a duplicate of some other text, and thus we could view it as non-normative here.

@HansOlsson HansOlsson merged commit 29b6c89 into modelica:master Feb 27, 2020
@HansOlsson HansOlsson deleted the ModelClass branch February 27, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model no longer identical to class
2 participants