Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReadMe.md #2549

Merged
merged 2 commits into from Apr 22, 2020
Merged

Update ReadMe.md #2549

merged 2 commits into from Apr 22, 2020

Conversation

HansOlsson
Copy link
Collaborator

Add new MCP as planned on last phone meeting.

Add new MCP as planned.
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but in general I think it is better to describe this kind of commit as Allocating MCP number for…, so that it is easily recognized as a kind of commit that needs (or at least needs to be based on) a language group decision.

@@ -17,7 +17,8 @@ New MCP should be added to the following list - on the main branch to keep track
but the rest of the development on a branch/pull-request before being accepted.

## List of existing MCPs
- MCP0035 Multilingual support od Modelica([MCP/0035](https://github.com/modelica/ModelicaSpecification/tree/MCP/0035/RationaleMCP/0035))
- MCP0036 Setting statues ([MCP/0036]) (https://github.com/modelica/ModelicaSpecification/tree/MCP/0036/RationaleMCP/0036))
- MCP0035 Multilingual support of Modelica([MCP/0035](https://github.com/modelica/ModelicaSpecification/tree/MCP/0035/RationaleMCP/0035))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This spelling fix should go in a separate commit.)

@@ -17,7 +17,8 @@ New MCP should be added to the following list - on the main branch to keep track
but the rest of the development on a branch/pull-request before being accepted.

## List of existing MCPs
- MCP0035 Multilingual support od Modelica([MCP/0035](https://github.com/modelica/ModelicaSpecification/tree/MCP/0035/RationaleMCP/0035))
- MCP0036 Setting statues ([MCP/0036]) (https://github.com/modelica/ModelicaSpecification/tree/MCP/0036/RationaleMCP/0036))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling mistake in statues.

@gkurzbach
Copy link
Collaborator

Sorry, but what was the concrete aim of this MCP?

Copy link
Collaborator

@gkurzbach gkurzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little bit confused from the type in the name of the MCP. But now I found the right readme.md file and can confirm to it.

@HansOlsson HansOlsson merged commit ad7aebd into master Apr 22, 2020
@HansOlsson HansOlsson deleted the HansOlsson-patch-1 branch April 22, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants