-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve and make use of 'definition' environment #2601
Conversation
This may, we get a referencing mechanism that also works with LaTeXML.
This is a very simple solution to start with. For PDF output, there are definitely more advanced variants to consider, but the question is what would also work well (look good) with LaTeXML.
… variables It hurts a little to break the table apart, but I think it has to be done in the spirit of consistency.
9652634
to
d809699
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I have two minor concerns in the synchronous chapter (which had severe problems before as well):
- The figures for piecewise-constant (etc) look a bit odd with the new format. And 16.3 seems redundant with 16.4. One possibility would be to replace those three figures by one larger figure containing everything; and "hold(r)" for the green dotted line.
- The style of "[The input argument is a] component expression" looks a bit odd, but I don't know how to best format that - maybe it was better without []?. Clearly "component expression" is the main part, but the definition above already defined "component expression".
Yes, it is really hard to make this nice. I think the real problem here is that the the terms being defined are just too long because of the need to also give that context (the input argument is a) as part of the definition. I think one can take a step back here, and see that we aren't actually defining three new concepts here, just putting already defined concepts in a particular context. Let's see what that would look like… |
I'm working on it, but it takes time to find a solution that works with both |
Addressing comment that got lost in #2601.
Fixes #2570.