Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and make use of 'definition' environment #2601

Merged
merged 8 commits into from
Jun 26, 2020

Conversation

henrikt-ma
Copy link
Collaborator

Fixes #2570.

This may, we get a referencing mechanism that also works with LaTeXML.
This is a very simple solution to start with.  For PDF output, there are definitely more advanced variants to consider, but the question is what would also work well (look good) with LaTeXML.
… variables

It hurts a little to break the table apart, but I think it has to be done in the spirit of consistency.
Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have two minor concerns in the synchronous chapter (which had severe problems before as well):

  • The figures for piecewise-constant (etc) look a bit odd with the new format. And 16.3 seems redundant with 16.4. One possibility would be to replace those three figures by one larger figure containing everything; and "hold(r)" for the green dotted line.
  • The style of "[The input argument is a] component expression" looks a bit odd, but I don't know how to best format that - maybe it was better without []?. Clearly "component expression" is the main part, but the definition above already defined "component expression".

@henrikt-ma
Copy link
Collaborator Author

  • The style of "[The input argument is a] component expression" looks a bit odd, but I don't know how to best format that - maybe it was better without []?. Clearly "component expression" is the main part, but the definition above already defined "component expression".

Yes, it is really hard to make this nice. I think the real problem here is that the the terms being defined are just too long because of the need to also give that context (the input argument is a) as part of the definition. I think one can take a step back here, and see that we aren't actually defining three new concepts here, just putting already defined concepts in a particular context. Let's see what that would look like…

@henrikt-ma
Copy link
Collaborator Author

henrikt-ma commented Jun 25, 2020

  • The figures for piecewise-constant (etc) look a bit odd with the new format. And 16.3 seems redundant with 16.4. One possibility would be to replace those three figures by one larger figure containing everything; and "hold(r)" for the green dotted line.

I'm working on it, but it takes time to find a solution that works with both \autoref and LaTeXML… I'd say it's better to merge now without waiting for the solution.

@HansOlsson HansOlsson merged commit bd9c702 into master Jun 26, 2020
@HansOlsson HansOlsson deleted the cleanup/definitions branch June 26, 2020 07:15
henrikt-ma added a commit that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many kinds of definitions
2 participants