Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make assertion level a structural parameter #2698

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Make assertion level a structural parameter #2698

merged 2 commits into from
Nov 6, 2020

Conversation

henrikt-ma
Copy link
Collaborator

@henrikt-ma henrikt-ma commented Nov 2, 2020 •
edited

Fixes #2642

maltelenz
maltelenz approved these changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
You probably mean that this fixes #2642 though, not #2692.

@henrikt-ma
Copy link
Collaborator Author

Looks good to me.
You probably mean that this fixes #2642 though, not #2692.

Thanks! It's the second time this has happened to me recently. I'm wondering if it's something with the aggressive auto-completion on GitHub that's changing the issue numbers for me…

HansOlsson
HansOlsson approved these changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I was first a bit surprised by the change of parameter-expression, but since we almost everywhere else use 'parameter expression' it makes sense to be consistent.

@HansOlsson HansOlsson merged commit 4775c21 into modelica:master Nov 6, 2020
@henrikt-ma henrikt-ma deleted the assertionlevel-variability branch November 6, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltelenz maltelenz maltelenz approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can AssertionLevel change dynamically?
3 participants
@henrikt-ma @maltelenz @HansOlsson