Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling of document title, front pages, and navbar #2724

Merged

Conversation

henrikt-ma
Copy link
Collaborator

This PR is a mix of various fixes related to styling of the document title, the document front pages, and the navbar. Most notable changes (see individual commit messages for a more detailed list):

  • The HTML title bar is cleaner.
  • When collapsed, the navbar now sits up in the left corner, but substantially wider than before.
  • The abstract is back on the front page of the PDF, and copyright stuff goes on a separate page before the table of contents.

@HansOlsson, is it possible to avoid squashing commits when merging? Squashing makes it much harder for me to safely remove my local branches, as they are not known to be merged by Git.

This results in a menu that is easier to expand using a finger on a small touch screen, and at the same time giving more horizontal space for reading the main content.
Reasons to not show:
- Highly unlikely to be used (more meaningful when each page is short, and a reader is expected to read one page after another).
- Occupies space that is precious on small screens.
- Current layout breaks when window is so narrow that these links would overlap.
I don't see any reason why the starred form was introduced in the first place, so it's probably better to go with the more intelligent form.
This makes the \title work better in the LaTeXML output.
This also restores the 3.4 look with the abstract on the PDF front page.
MLS.tex Outdated Show resolved Hide resolved
@HansOlsson HansOlsson self-requested a review November 19, 2020 14:58
Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result looks good.

@HansOlsson HansOlsson merged commit 0ebd078 into modelica:master Nov 19, 2020
@HansOlsson
Copy link
Collaborator

@HansOlsson, is it possible to avoid squashing commits when merging? Squashing makes it much harder for me to safely remove my local branches, as they are not known to be merged by Git.

Ok, I have tried to have the general rule that if it were just multiple commits to one file and place in the file (fixing one more issue, typo etc) I squashed it to make the master cleaner; whereas in other cases (primarily commits for different files) I didn't squash, since that loses information.

@henrikt-ma
Copy link
Collaborator Author

Ok, I have tried to have the general rule that if it were just multiple commits to one file and place in the file (fixing one more issue, typo etc) I squashed it to make the master cleaner; whereas in other cases (primarily commits for different files) I didn't squash, since that loses information.

OK, I see, I just wanted to make you aware of this safe-branch-pruning aspect to the squashing.

@henrikt-ma henrikt-ma deleted the styling/titles-navbar-and-front-page branch November 19, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants