Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated link to doc.modelica.org #2729

Merged
merged 1 commit into from Nov 25, 2020
Merged

Remove outdated link to doc.modelica.org #2729

merged 1 commit into from Nov 25, 2020

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Nov 21, 2020

Only link to OM generated help of MSL v4.0.0.

Alternatively (and avoiding the version dependency in the specification) we can update http://doc.modelica.org/om/Modelica.UsersGuide.html to redirect to https://doc.modelica.org/Modelica%204.0.0/Resources/helpOM/Modelica.html.

@HansOlsson
Copy link
Collaborator

Only link to OM generated help of MSL v4.0.0.

Alternatively (and avoiding the version dependency in the specification) we can update http://doc.modelica.org/om/Modelica.UsersGuide.html to redirect to https://doc.modelica.org/Modelica%204.0.0/Resources/helpOM/Modelica.html.

I agree that just one link would be preferable, but to me another way of reducing dependencies would be to just link to https://github.com/modelica/ModelicaStandardLibrary as that would seem like the natural landing point for someone interested in MSL. It may be that the actual overview (or user's guide) is a bit too hidden on that page, but then it would make sense to modify it to make it more visible.

@beutlich
Copy link
Member Author

Fine for me to only link to https://github.com/modelica/ModelicaStandardLibrary.

And right, while doc.modelica.org is prominently display in various links at https://github.com/modelica/ModelicaStandardLibrary, we have no dedicated link to its Users Guide.

@HansOlsson
Copy link
Collaborator

Fine for me to only link to https://github.com/modelica/ModelicaStandardLibrary.

Can you update the PR?

And right, while doc.modelica.org is prominently display in various links at https://github.com/modelica/ModelicaStandardLibrary, we have no dedicated link to its Users Guide.

I leave that to MAP-Lib.

Only link to GitHub repository of MSL
@beutlich
Copy link
Member Author

Can you update the PR?

Done.

Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@HansOlsson HansOlsson merged commit 6627ca6 into master Nov 25, 2020
@HansOlsson HansOlsson deleted the fix-link branch November 25, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants