Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change input points to const for C. #2767

Merged
merged 5 commits into from
Dec 17, 2020
Merged

Change input points to const for C. #2767

merged 5 commits into from
Dec 17, 2020

Conversation

HansOlsson
Copy link
Collaborator

Closes #1955

@HansOlsson HansOlsson added this to the ModelicaSpec3.5 milestone Dec 15, 2020
henrikt-ma
henrikt-ma requested changes Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note regarding array inputs being const pointers needs at least some change.

Other than than, I'm just assuming that the table with the added column looks good.

chapters/functions.tex Outdated Show resolved Hide resolved
@HansOlsson
Copy link
Collaborator Author

Note regarding array inputs being const pointers needs at least some change.

Other than than, I'm just assuming that the table with the added column looks good.

Hmm... Looking closely it actually seems a bit too wide. I'll try a somewhat odd change to handle that.

henrikt-ma
henrikt-ma approved these changes Dec 16, 2020
View reviewed changes
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting way to keep down the width of the table.

@HansOlsson HansOlsson removed the request for review from GallLeo December 17, 2020 07:00
@HansOlsson HansOlsson merged commit 3875c08 into modelica:master Dec 17, 2020
@HansOlsson HansOlsson deleted the ConstC branch December 17, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikt-ma henrikt-ma henrikt-ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ModelicaSpec3.5
Development

Successfully merging this pull request may close these issues.

Const array inputs to external C functions
2 participants
@HansOlsson @henrikt-ma