Add SourceDirectory - with current restrictions. #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beutlich
approved these changes
Dec 23, 2020
henrikt-ma
approved these changes
Dec 23, 2020
There was a problem hiding this comment.
Seems to agree with current status of the poll #2145 (comment).
It would have been even better if there was a comment concluding the poll to make it really clear which resolution this PR is actually supposed to implement. This becomes extra important in case the poll would keep getting more votes efter after it has been closed.
Added now, I had already planned that - it was just that I wanted to have the PRs ready before that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2145