Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated based on preliminary decision. #2779

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

HansOlsson
Copy link
Collaborator

Closes #2288

Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on being what I believe is a better match with what was originally agreed on in the phone meeting.

The poll in the discussion that followed, however, doesn't look decisive to me. My interpretation of this is that merging Evaluate annotations is a topic we might come back to in the future if the current design doesn't serve us well.

@HansOlsson
Copy link
Collaborator Author

Approving based on being what I believe is a better match with what was originally agreed on in the phone meeting.

The poll in the discussion that followed, however, doesn't look decisive to me. My interpretation of this is that merging Evaluate annotations is a topic we might come back to in the future if the current design doesn't serve us well.

I agree that this is likely, but that shouldn't prevent us from having some rule at the moment.

@HansOlsson HansOlsson removed the request for review from dietmarw December 28, 2020 09:24
@HansOlsson HansOlsson merged commit 59ce08a into modelica:master Dec 28, 2020
@HansOlsson HansOlsson deleted the UpdateEvalute branch December 28, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardise Evaluate = true handling on records
2 participants