Align duplicated parts of lexing rules #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't the first time we have issues with these being out of sync. Hopefully, maintenance will become easier now with the duplicated part being a substring of the full lexing rules.
10 tasks
GallLeo
approved these changes
Feb 1, 2021
It is because we are humans that we need to keep things as simple as possible and remove unnecessary variations. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't the first time we have issues with these being out of sync. Hopefully, maintenance will become easier now with the duplicated part being a substring of the full lexing rules.
Addresses one of the items in #2825:
@HansOlsson: This is another PR where it would be good to have a documented procedure for also targeting the current maintenance branch.