Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing plural 's' #2860

Merged
merged 1 commit into from Feb 19, 2021

Conversation

henrikt-ma
Copy link
Collaborator

@henrikt-ma henrikt-ma commented Feb 19, 2021

This is a commit I had forgotten to push for #2856.

Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. This is one of the cases where it may make sense to have two commits - one to fix line breaks and one to fix the problem to make it easier to find the change.

@HansOlsson HansOlsson merged commit 77eb136 into modelica:master Feb 19, 2021
@henrikt-ma henrikt-ma deleted the cleanup/colon-dim-itemize branch February 19, 2021 08:34
@henrikt-ma
Copy link
Collaborator Author

Ok. This is one of the cases where it may make sense to have two commits - one to fix line breaks and one to fix the problem to make it easier to find the change.

Absolutely! However, I'm more concerned about upcoming changes like when we have agreed on a style guide. There will be lots of small changes spread out throughout the entire document, and having to make every little change in two steps will be rather annoying… Then imagine having ongoing work for the implementation of Ternary in a parallel branch…

@HansOlsson HansOlsson added the M36 For pull requests merged into Modelica 3.6 label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M36 For pull requests merged into Modelica 3.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants