-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gather annotations for functions #2922
Gather annotations for functions #2922
Conversation
2d40ca1
to
891f414
Compare
It looks better with all link sections at the end of the chapter having the same depth, and having a \subsection structure is also bloating the table of contents with no real gain.
…ith section above
… related sections
Considering that the goal is to have something ready for the upcoming phone meeting, there is no time for polishing this more before collecting feed-back. Removing Draft state. |
…ction-annotations
Dear reviewers, as there were no comments yet I took the opportunity to improve this PR further by matching the styles of how we present the annotations in the Functions chapter. Still seeking reviews, so that we can move forward on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good except for the minor change.
Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Except for the conflict that should now be resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
||
\begin{annotationdefinition}[Inline] | ||
\begin{annotationdefinition}[experiment] | ||
% henrikt-ma 2021-04: Seems strange to allow 'experiment' completely without list of options -- what would it mean? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we open a ticket about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion, but it seems like this comment was lost when the PR was closed. Opened #2985.
Fixes #2895.
This is still work in progress, reflected by the Draft state – the PR is initiated just to show intention of having something ready for the upcoming phone meeting.