Gather annotations for functions #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
force-pushed
the
cleanup/gather-function-annotations
branch
from
2d40ca1
to
891f414
Compare
It looks better with all link sections at the end of the chapter having the same depth, and having a \subsection structure is also bloating the table of contents with no real gain.
…ith section above
… related sections
|
Considering that the goal is to have something ready for the upcoming phone meeting, there is no time for polishing this more before collecting feed-back. Removing Draft state. |
Merged
…ction-annotations
|
Dear reviewers, as there were no comments yet I took the opportunity to improve this PR further by matching the styles of how we present the annotations in the Functions chapter. Still seeking reviews, so that we can move forward on this. |
HansOlsson
reviewed
May 21, 2021
HansOlsson
requested changes
May 21, 2021
Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>
Except for the conflict that should now be resolved. |
eshmoylova
approved these changes
May 26, 2021
|
|
||
| \begin{annotationdefinition}[Inline] | ||
| \begin{annotationdefinition}[experiment] | ||
| % henrikt-ma 2021-04: Seems strange to allow 'experiment' completely without list of options -- what would it mean? |
There was a problem hiding this comment.
Should we open a ticket about it?
There was a problem hiding this comment.
Good suggestion, but it seems like this comment was lost when the PR was closed. Opened #2985.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2895.
This is still work in progress, reflected by the Draft state – the PR is initiated just to show intention of having something ready for the upcoming phone meeting.