Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting of 'when', 'elsewhen', and 'when initial()' #3000

Merged
merged 1 commit into from Sep 16, 2021
Merged

Fix formatting of 'when', 'elsewhen', and 'when initial()' #3000

merged 1 commit into from Sep 16, 2021

Conversation

henrikt-ma
Copy link
Collaborator

No description provided.

HansOlsson
HansOlsson approved these changes Sep 15, 2021
View reviewed changes
Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, formatting, but the parenthesis does not make sense. (Not a new issue.)

Currently it says:
"having \lstinline!reinit! of the same variable in \lstinline!when! and \lstinline!elsewhen! of the same variable is allowed"
That seems repetitive and the second "same variable" should be something else: that reinit of the same variable should be possible in both when and elsewhen of one when-equation.

@henrikt-ma
Copy link
Collaborator Author

Ok, formatting, but the parenthesis does not make sense. (Not a new issue.)

Currently it says:
"having \lstinline!reinit! of the same variable in \lstinline!when! and \lstinline!elsewhen! of the same variable is allowed"
That seems repetitive and the second "same variable" should be something else: that reinit of the same variable should be possible in both when and elsewhen of one when-equation.

Right, but how about taking this part in #3001?

@HansOlsson HansOlsson merged commit abb1cc8 into modelica:master Sep 16, 2021
@henrikt-ma henrikt-ma mentioned this pull request Sep 17, 2021
Closed
@henrikt-ma henrikt-ma deleted the cleanup/reinit branch September 17, 2021 06:28
@HansOlsson HansOlsson added the M36 For pull requests merged into Modelica 3.6 label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees
No one assigned
Labels
M36 For pull requests merged into Modelica 3.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henrikt-ma @HansOlsson