-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow derivatives to be referenced in figures #3046
Allow derivatives to be referenced in figures #3046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For my information, what is the netiquette about "resolving conversations"? Who is entitled to resolve them? |
Well, the one "starting" the conversation should normally resolve it. But if missed it will still be marked as resolved if it is clear from the context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As stated I would like line 197 to be changed.
The other change is less important.
As decided at phone meeting: modelica#3046 (comment) Reorganizing slightly to avoid paragraph with just a single sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
Fixes #3004.
After two months without discussion in #3004 it is time for the next step in preparation for the upcoming web meeting.