Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow derivatives to be referenced in figures #3046

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

henrikt-ma
Copy link
Collaborator

Fixes #3004.

After two months without discussion in #3004 it is time for the next step in preparation for the upcoming web meeting.

Copy link
Collaborator

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chapters/annotations.tex Outdated Show resolved Hide resolved
@casella
Copy link
Collaborator

casella commented Nov 26, 2021

For my information, what is the netiquette about "resolving conversations"? Who is entitled to resolve them?

@HansOlsson
Copy link
Collaborator

For my information, what is the netiquette about "resolving conversations"? Who is entitled to resolve them?

Well, the one "starting" the conversation should normally resolve it. But if missed it will still be marked as resolved if it is clear from the context.

Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated I would like line 197 to be changed.
The other change is less important.

chapters/annotations.tex Outdated Show resolved Hide resolved
@HansOlsson HansOlsson added this to the Phone2021-6 milestone Dec 7, 2021
As decided at phone meeting: modelica#3046 (comment)

Reorganizing slightly to avoid paragraph with just a single sentence.
Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@HansOlsson HansOlsson merged commit d60e1ae into modelica:master Dec 10, 2021
@henrikt-ma henrikt-ma deleted the derivatives-in-figures branch December 10, 2021 10:57
@HansOlsson HansOlsson added the M36 For pull requests merged into Modelica 3.6 label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M36 For pull requests merged into Modelica 3.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure annotations don't support variable derivatives
4 participants