Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call the preferredView string the 'view' #3071

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

henrikt-ma
Copy link
Collaborator

Extracted from #3067 according to comment: #3067 (comment)

@HansOlsson
Copy link
Collaborator

Alternatively we could use "view" instead of "layer" from the old text; as both "diagram view" and "text view" have been used.
The problem is info/documentation, but that could be worked around like below.

The $\mathit{view}$ is a \lstinline!String! literal where \lstinline!"info"! means viewing the class documentation (or information), \lstinline!"diagram"! means diagram view, \lstinline!"icon" means icon view, and \lstinline!"text"! means Modelica text view.

@henrikt-ma
Copy link
Collaborator Author

Alternatively we could use "view" instead of "layer" from the old text; as both "diagram view" and "text view" have been used.
The problem is info/documentation, but that could be worked around like below.

Yeah, I'm mainly trying to avoid too much repetition, but if you feel strongly about more view and text in the sentence I'll just change.

@HansOlsson
Copy link
Collaborator

Yeah, I'm mainly trying to avoid too much repetition, but if you feel strongly about more view and text in the sentence I'll just change.

To me that repetition provides a sort of consistency.

Addressing feedback from Hans.
@henrikt-ma
Copy link
Collaborator Author

Yeah, I'm mainly trying to avoid too much repetition, but if you feel strongly about more view and text in the sentence I'll just change.

To me that repetition provides a sort of consistency.

OK, now at least two of them repeat view, and all of them repeat the string one way or another in the explanation.

Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@HansOlsson HansOlsson merged commit 4ee0321 into modelica:master Dec 10, 2021
@henrikt-ma henrikt-ma deleted the cleanup/preferredView-is-view branch December 10, 2021 18:09
@HansOlsson HansOlsson added the M36 For pull requests merged into Modelica 3.6 label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M36 For pull requests merged into Modelica 3.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants