Limiting number of connections. #3212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Remove 2nd one; turn into separate PR." This reverts commit 9ea8d41.
|
This should now be accepted based on the poll #3213 confirmed by the phone meeting. |
henrikt-ma
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
The poll with its two participants is predates the more informed comments by @casella, and I must admit that I don't have clear memories of the phone meeting expressing any particular opinion on the matter. On the other hand, it seems like @casella is the only person who has given any sort of constructive feedback on the proposal, and as he is fine with it now I'll simply reflect this in the form of an approving review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Remove 2nd one; turn into separate PR."
This reverts commit 9ea8d41.
As I see it there are two possibilities here:
Please redirect discussions to the other PR to be created.