Extend choicesAllMatching to records. #3229
Conversation
There was a problem hiding this comment.
Mainly requesting that the big example is split into three smaller examples.
Other than that, this looks like an OK implementation of what the poll suggested in #3210 (comment). A language group meeting decision based on the poll would be nice, but I'm not sure we really need it for a small change like this when every participant in the poll was in favor.
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Elena Shmoylova <eshmoylova@users.noreply.github.com>
Co-authored-by: Elena Shmoylova <eshmoylova@users.noreply.github.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
And also specify that only recommend to present choices anyway for replaceable.
There was a problem hiding this comment.
The breakdown of the example looks good now. I'm ready to provide an approving review as soon as I can point to a language group agreement to go with the poll in #3210 (comment).
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
To me that poll is the language group agreement; as a simplified on-line poll in the language group where people have at least one week to participate (which is one of the alternatives in the work-flow). |
|
No objection during phone meeting. |
Even if the language group isn't asked to take a phone meeting decision based on the poll, I find the "polling comment" itself too unstable to be worth referencing. The least one could do would be to add another comment after the poll has been closed (in the same issue as the poll itself), summarizing the votes given in the poll and writing down a decision about how to proceed. |
There was a problem hiding this comment.
I'll take #3229 (comment) as a note of a language group decision to go forward along with the poll result in #3210 (comment), where 5 out of 5 votes were In favor.
Ok, will add such comments in the future. |
Closes #3210
(Based on decision, and examples cleaned up to clarify what they actually show, since "it" isn't good enough.)