Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid zero delay. #3251

Merged
merged 1 commit into from Nov 1, 2022
Merged

Forbid zero delay. #3251

merged 1 commit into from Nov 1, 2022

Conversation

HansOlsson
Copy link
Collaborator

Closes #3245
Due to the problems with potential systems of equations for zero delay I don't see any other solution.

Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As usual, before providing a review with approval, I'd like to see some sort of language group decision to make such a backwards incompatible change (maybe someone needs to be convinced that there isn't any other solution).

@HansOlsson
Copy link
Collaborator Author

Note that the problematic part has been present since Modelica 1.1.

@eshmoylova
Copy link
Member

We check for strictly positive value and throw an error if it is not.

@HansOlsson HansOlsson added this to the Phone 2022-5 milestone Oct 6, 2022
@HansOlsson
Copy link
Collaborator Author

Agreement by acclamation.

@HansOlsson HansOlsson merged commit c7631f7 into modelica:master Nov 1, 2022
@HansOlsson HansOlsson deleted the PositiveDelay branch November 1, 2022 15:03
@HansOlsson HansOlsson added the M36 For pull requests merged into Modelica 3.6 label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M36 For pull requests merged into Modelica 3.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow zero delay
3 participants