Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to clarify design pattern. #3252

Merged
merged 2 commits into from May 29, 2023

Conversation

HansOlsson
Copy link
Collaborator

Closes #3242
Does this more clearly define that the design pattern is special and the rules don't apply in other cases?

@HansOlsson HansOlsson added this to the Phone 2022-5 milestone Oct 10, 2022
@HansOlsson
Copy link
Collaborator Author

@casella do you agree with new text?

Copy link
Collaborator

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment to the proposed text change

chapters/classes.tex Outdated Show resolved Hide resolved
Copy link
Collaborator

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansOlsson HansOlsson merged commit 173d0de into modelica:master May 29, 2023
@HansOlsson HansOlsson deleted the ClarifySpecialPattern branch May 29, 2023 11:27
@casella
Copy link
Collaborator

casella commented May 29, 2023

As I wrote last November, I'm still doubtful how can users (and tools checking models) tell apart the cases (such as Modelica.Blocks) which are meant to be used with connect statements, from the case (such as Modelica.Media) where they aren't.

@HansOlsson HansOlsson added the M37 For pull requests merged into Modelica 3.7 label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M37 For pull requests merged into Modelica 3.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about connector inputs
2 participants