Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain array assignments with implicit iterators. #3306

Merged
merged 15 commits into from
Jan 2, 2023
Merged

Constrain array assignments with implicit iterators. #3306

merged 15 commits into from
Jan 2, 2023

Conversation

HansOlsson
Copy link
Collaborator

Closes #3250

qlambert-pro
qlambert-pro reviewed Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@qlambert-pro qlambert-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

henrikt-ma
henrikt-ma requested changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One way or another, it would be good to keep the normative content in one place (before the example).

chapters/statements.tex Outdated Show resolved Hide resolved
henrikt-ma
henrikt-ma reviewed Dec 13, 2022
View reviewed changes
chapters/statements.tex Outdated Show resolved Hide resolved
This was referenced Dec 13, 2022
Merged
Closed
henrikt-ma
henrikt-ma reviewed Dec 14, 2022
View reviewed changes
chapters/abstract.tex Outdated Show resolved Hide resolved
henrikt-ma
henrikt-ma reviewed Dec 14, 2022
View reviewed changes
chapters/equations.tex Outdated Show resolved Hide resolved
HansOlsson
HansOlsson commented Dec 20, 2022
View reviewed changes
chapters/abstract.tex Outdated Show resolved Hide resolved
HansOlsson
HansOlsson commented Dec 20, 2022
View reviewed changes
chapters/equations.tex Outdated Show resolved Hide resolved
henrikt-ma
henrikt-ma approved these changes Dec 27, 2022
View reviewed changes
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@HansOlsson HansOlsson merged commit aaaf6ad into modelica:master Jan 2, 2023
@HansOlsson HansOlsson deleted the ConstrainArrayAssignment branch January 2, 2023 09:20
@HansOlsson HansOlsson added the M36 For pull requests merged into Modelica 3.6 label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qlambert-pro qlambert-pro qlambert-pro left review comments

@henrikt-ma henrikt-ma henrikt-ma approved these changes

Assignees
No one assigned
Labels
M36 For pull requests merged into Modelica 3.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Constraint on arrays used to determine implicit iterators.
3 participants
@HansOlsson @qlambert-pro @henrikt-ma