Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interface.tex #3341

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Update interface.tex #3341

merged 1 commit into from
Mar 2, 2023

Conversation

gwr69
Copy link
Contributor

@gwr69 gwr69 commented Feb 15, 2023

Minor omission here: The class record is missing in the example for the other record R2.

Minor omission here: The class `record` is missing in the example for the other record R2.
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@HansOlsson
Copy link
Collaborator

However, as I understand the rules this has to wait until the vote for 3.6 is complete as there is no exception for even such changes. We might still include it in maintenance branch for 3.6.

@HansOlsson HansOlsson added the example Issue regarding example in specification label Mar 2, 2023
@HansOlsson HansOlsson merged commit 72181d2 into modelica:master Mar 2, 2023
@gwr69 gwr69 deleted the patch-1 branch March 2, 2023 11:10
@HansOlsson HansOlsson added the M36 For pull requests merged into Modelica 3.6 label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example Issue regarding example in specification M36 For pull requests merged into Modelica 3.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants