Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While event #3360

Merged
merged 15 commits into from May 30, 2023
Merged

While event #3360

merged 15 commits into from May 30, 2023

Conversation

HansOlsson
Copy link
Collaborator

Closes #3321
Clarify that you need noEvent around while-statements to avoid events (except for deprecated feature).

chapters/statements.tex Outdated Show resolved Hide resolved
chapters/statements.tex Outdated Show resolved Hide resolved
chapters/statements.tex Outdated Show resolved Hide resolved
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from suggestions, I am missing some changes in other parts of the document:

  • for-equations
  • array reductions

HansOlsson and others added 4 commits April 21, 2023 08:22
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
@HansOlsson
Copy link
Collaborator Author

As for the others:

@HansOlsson
Copy link
Collaborator Author

Apart from suggestions, I am missing some changes in other parts of the document:

  • for-equations
  • array reductions

As indicated they are now included.

chapters/arrays.tex Outdated Show resolved Hide resolved
@henrikt-ma
Copy link
Collaborator

Yes, this is what was decided in #3321 (comment).

chapters/arrays.tex Outdated Show resolved Hide resolved
chapters/statements.tex Outdated Show resolved Hide resolved
chapters/statements.tex Outdated Show resolved Hide resolved
chapters/statements.tex Outdated Show resolved Hide resolved
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, and the need for a for-equation range to be evaluable.

HansOlsson and others added 8 commits May 12, 2023 13:19
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
@HansOlsson
Copy link
Collaborator Author

Some small comments, and the need for a for-equation range to be evaluable.

Now corrected.

chapters/equations.tex Outdated Show resolved Hide resolved
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from minor wording suggestion.

Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
Copy link
Collaborator

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@HansOlsson HansOlsson merged commit 712eb9a into modelica:master May 30, 2023
1 check passed
@HansOlsson HansOlsson deleted the WhileEvent branch May 30, 2023 09:51
@HansOlsson HansOlsson added the M37 For pull requests merged into Modelica 3.7 label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M37 For pull requests merged into Modelica 3.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event-generation in while-loop condition
2 participants