Fix11 #3403
Merged
Fix11 #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can find lots of completely incorrect interpretations of the original text.
eshmoylova
requested changes
Aug 12, 2023
Co-authored-by: Elena Shmoylova <eshmoylova@users.noreply.github.com>
eshmoylova
approved these changes
Aug 14, 2023
henrikt-ma
reviewed
Aug 14, 2023
henrikt-ma
reviewed
Aug 14, 2023
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
henrikt-ma
reviewed
Aug 14, 2023
henrikt-ma
requested changes
Aug 14, 2023
Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
|
@henrikt-ma ok now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we repeatedly find cases where errors that have remained from version 1.1 of the specification I'm going through that version and looking for problems.
I also found that:
ModelicaSpecification/chapters/equations.tex
Line 106 in 07ccecd
is problematic ("once"? what if the for-equation is nested?), but I couldn't find any good alternative.