Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify complicated sentence about 'input' prefix exception in functions #3430

Merged

Conversation

henrikt-ma
Copy link
Collaborator

The previous formulation didn't make sense grammatically to me, as I expected another condition for the exception to apply following the and. This PR fixes this along with writing out a few more things that make the rule easier to parse.

@perost
Copy link
Collaborator

perost commented Nov 6, 2023

I think special class should be changed to specialized class in the first sentence too while you're at it.

@henrikt-ma
Copy link
Collaborator Author

I think special class should be changed to specialized class in the first sentence too while you're at it.

Done.

Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, makes sense.

@HansOlsson HansOlsson merged commit 6367899 into modelica:master Nov 9, 2023
1 check passed
@HansOlsson HansOlsson added the M37 For pull requests merged into Modelica 3.7 label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M37 For pull requests merged into Modelica 3.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants