Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend recent commit with missing \lstinline markup #3447

Merged
merged 1 commit into from Nov 21, 2023
Merged

Amend recent commit with missing \lstinline markup #3447

merged 1 commit into from Nov 21, 2023

Conversation

henrikt-ma
Copy link
Collaborator

No description provided.

HansOlsson
HansOlsson approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HansOlsson
Copy link
Collaborator

I checked through the history and it has gone through various iterations, and I believe the new variant is the clearest without being verbose.

@henrikt-ma
Copy link
Collaborator Author

I checked through the history and it has gone through various iterations, and I believe the new variant is the clearest without being verbose.

Was this comment perhaps meant for some other issue?

@HansOlsson
Copy link
Collaborator

I checked through the history and it has gone through various iterations, and I believe the new variant is the clearest without being verbose.

Was this comment perhaps meant for some other issue?

This issue. The specific text has been changed back and forth a bit.

@HansOlsson HansOlsson merged commit ea1c6ba into modelica:master Nov 21, 2023
1 check passed
@henrikt-ma henrikt-ma deleted the cleanup/function-input-output branch November 23, 2023 21:50
@HansOlsson HansOlsson added the M37 For pull requests merged into Modelica 3.7 label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees
No one assigned
Labels
M37 For pull requests merged into Modelica 3.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henrikt-ma @HansOlsson