Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Figure.group is a figure group, not a plot group #3477

Merged
merged 1 commit into from Feb 15, 2024

Conversation

henrikt-ma
Copy link
Collaborator

Small cleanup, loosely related to #3475 and #3473.

Copy link
Collaborator

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a clearly correct fix to me.

Copy link
Collaborator

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but one might also rephrase it as "Name of the group of figures"; but I guess that will involve more updates

@henrikt-ma
Copy link
Collaborator Author

Looks ok, but one might also rephrase it as "Name of the group of figures"; but I guess that will involve more updates

To me, changing to Name of the group of figures is only a more verbose way of saying the same thing as today, and would suggest that we use the more verbose way of writing descriptions everywhere. To me that seems mostly like a waste of space (not least in view of the line length restrictions in the PDF), so I prefer the style of short description strings combined with clear explanations in the text.

@HansOlsson HansOlsson merged commit 4f9fced into modelica:master Feb 15, 2024
1 check passed
@henrikt-ma henrikt-ma deleted the cleanup/figure-group branch February 16, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants