Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally uninitialized local variable dbrgdb in Modelica.Electrical.Spice3.Internal.Mos2.drainCurRevised used #1425

Closed
modelica-trac-importer opened this issue Jan 14, 2017 · 3 comments
Closed

Conditionally uninitialized local variable dbrgdb in Modelica.Electrical.Spice3.Internal.Mos2.drainCurRevised used #1425

modelica-trac-importer opened this issue Jan 14, 2017 · 3 comments
Assignees
@beutlich @ECClauss
Labels
enhancement New feature or enhancement L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3 P: low Low priority issue
Milestone
MSL3.2.3

Comments

@modelica-trac-importer
Copy link

Reported by jfrenkel on 17 Feb 2014 13:47 UTC
In the function Modelica.Electrical.Spice3.Internal.Mos2.drainCurRevised is the local variable dbsrdb only initialised if the input vds <> 0.0. Otherwise the local variable dbsrdb is used if vgs <= out_c.m_von and vds > out_c.m_vdsat is. These seems to be true in the most cases but it would be good to have a defined value in all cases.

Migrated-From: https://trac.modelica.org/Modelica/ticket/1425
@modelica-trac-importer modelica-trac-importer added enhancement New feature or enhancement L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3 P: low Low priority issue labels Jan 14, 2017
@modelica-trac-importer
Copy link
Author

Comment by jfrenkel on 17 Feb 2014 13:50 UTC
The same issue is in the function Modelica.Electrical.Spice3.Internal.Mos2.drainCur.

@modelica-trac-importer
Copy link
Author

Comment by jfrenkel on 17 Feb 2014 13:58 UTC
The same issue in the functions Modelica.Electrical.Spice3.Internal.Mos2.drainCurRevised and Modelica.Electrical.Spice3.Internal.Mos2.drainCur is there for the local variable x4. It is only initialised if delta4 >= 0.

Closed
@beutlich beutlich self-assigned this Apr 19, 2017
@beutlich beutlich added this to the MSL_next-MINOR-version milestone Apr 19, 2017
beutlich added a commit that referenced this issue Apr 19, 2017
@beutlich
refs #1425: Avoid conditionally uninitialized variables
705d168
@beutlich
Copy link
Member

@FrenkelJ Resolved in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beutlich beutlich

@ECClauss ECClauss

Labels
enhancement New feature or enhancement L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3 P: low Low priority issue
Projects
None yet
Milestone
MSL3.2.3
Development

No branches or pull requests
3 participants
@beutlich @modelica-trac-importer @ECClauss