Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not quite 90 degrees, in Modelica.Mechanics.Rotational.Examples.CoupledClutches #1975

Closed
modelica-trac-importer opened this issue Jan 15, 2017 · 1 comment
Closed

Not quite 90 degrees, in Modelica.Mechanics.Rotational.Examples.CoupledClutches #1975

modelica-trac-importer opened this issue Jan 15, 2017 · 1 comment
Assignees
@MartinOtter @beutlich
Labels
example Issue only addresses example(s) L: Blocks Issue addresses Modelica.Blocks L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational P: low Low priority issue
Milestone
MSL3.2.3

Comments

@modelica-trac-importer
Copy link

Reported by hansolsson on 4 Apr 2016 12:54 UTC
Some example models use 1.57 as an approximation for pi/2 - that seems a bit inaccurate, and is especially an issue if you look at it in degrees:

Modelica.Mechanics.Rotational.Examples.CoupledClutches
Modelica.Blocks.Examples.PID_Controller

I would prefer to use more digits - even if it requires updated reference results for these two models.

Whereas the following ones use a good value (also for 45 degrees).
Modelica.Mechanics.Rotational.Examples.Backlash
Modelica.Fluid.Fittings.BaseClasses.Bends.CurvedBend.Geometry
Modelica.Mechanics.MultiBody.Examples.Elementary.RollingWheelSetDriving

(The ones for pi also use good values, and 2*pi is only used in Modelica.Electrical.Analog.Examples.ShowSaturatingInductor for stopTime and it seems good enough.)

Clearly this is not a blocking issue.

Migrated-From: https://trac.modelica.org/Modelica/ticket/1975
@modelica-trac-importer modelica-trac-importer added this to the MSL_next-MINOR-version milestone Jan 15, 2017
@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational P: low Low priority issue labels Jan 15, 2017
@tbeu tbeu added the L: Blocks Issue addresses Modelica.Blocks label Feb 3, 2017
beutlich added a commit that referenced this issue Feb 3, 2017
@beutlich
refs #1975: Use more accurate approximations of pi/2
7204813
beutlich added a commit that referenced this issue Feb 3, 2017
@beutlich
refs #1975: Use more accurate approximations of pi/2
659e2d0
@beutlich beutlich self-assigned this Feb 3, 2017
@beutlich
Copy link
Member

beutlich commented Feb 3, 2017

@HansOlsson Resolved in the most straight-forward way in branches master and maint/3.2.2.

@beutlich beutlich closed this as completed Feb 3, 2017
@beutlich beutlich added example Issue only addresses example(s) and removed bug Critical/severe issue labels May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinOtter MartinOtter

@beutlich beutlich

Labels
example Issue only addresses example(s) L: Blocks Issue addresses Modelica.Blocks L: Mechanics.Rotational Issue addresses Modelica.Mechanics.Rotational P: low Low priority issue
Projects
None yet
Milestone
MSL3.2.3
Development

No branches or pull requests
4 participants
@tbeu @MartinOtter @beutlich @modelica-trac-importer