Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restarted simulation of CombiTimeTable with periodic extrapolation can give wrong results #2040

Closed
modelica-trac-importer opened this issue Jan 15, 2017 · 4 comments
Closed

Restarted simulation of CombiTimeTable with periodic extrapolation can give wrong results #2040

modelica-trac-importer opened this issue Jan 15, 2017 · 4 comments
Assignees
@beutlich
Labels
bug Critical/severe issue L: C-Sources Issue addresses Modelica/Resources/C-Sources
Milestone
MSL3.2.3

Comments

@modelica-trac-importer
Copy link

Reported by beutlich on 5 Aug 2016 11:38 UTC
If a Modelica tool calls ModelicaStandardTables_CombiTimeTable_nextTimeEvent too often for a CombiTimeTable with periodic extrapolation, the internal states of the external table object (especially the offset and the event interval) are modified. Such a scenario happens e.g., for a restarted simulation of e.g., ModelicaTest.MultiBody.PlanarLoopWithMove). At the time of the table development (in spring 2013) the assumption was made that time is increasing only whereas a scenario of a restarted simulation was not considered. Hence, a restarted simulation can give wrong results for ModelicaStandardTables_CombiTimeTable_getValue.

Migrated-From: https://trac.modelica.org/Modelica/ticket/2040
@modelica-trac-importer modelica-trac-importer added this to the MSL_next-MAJOR-version milestone Jan 15, 2017
@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: C-Sources Issue addresses Modelica/Resources/C-Sources labels Jan 15, 2017
@modelica-trac-importer
Copy link
Author

Modified by beutlich on 5 Aug 2016 11:38 UTC

@modelica-trac-importer
Copy link
Author

Modified by beutlich on 5 Aug 2016 11:59 UTC

@modelica-trac-importer
Copy link
Author

Comment by beutlich on 10 Aug 2016 12:20 UTC
Resolved by 58507fc.

@modelica-trac-importer
Copy link
Author

Changelog modified by beutlich on 10 Aug 2016 12:20 UTC
Fixed event detection for restarted simulation

beutlich added a commit that referenced this issue Feb 16, 2017
@beutlich
refs #2040: Fix event detection for restarted simulation
3a51ab3 
git-svn-id: https://svn.modelica.org/projects/Modelica/trunk@9411 7ce873d0-865f-4ce7-a662-4bb36ea78beb

# Conflicts:
#	Modelica/Resources/C-Sources/ModelicaStandardTables.c
@beutlich beutlich modified the milestones: MSL_next-MINOR-version, MSL_next-MAJOR-version Feb 16, 2017
@beutlich beutlich changed the title Restarted simulation of ComiTimeTable with periodic extrapolation can give wrong results Restarted simulation of CombiTimeTable with periodic extrapolation can give wrong results Apr 19, 2017
dietmarw pushed a commit to dietmarw/ModelicaStandardLibrary that referenced this issue Oct 2, 2017
@beutlich
refs modelica#2040: Fix event detection for restarted simulation
58507fc 
git-svn-id: https://svn.modelica.org/projects/Modelica/trunk@9411 7ce873d0-865f-4ce7-a662-4bb36ea78beb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beutlich beutlich

Labels
bug Critical/severe issue L: C-Sources Issue addresses Modelica/Resources/C-Sources
Projects
None yet
Milestone
MSL3.2.3
Development

No branches or pull requests
2 participants
@beutlich @modelica-trac-importer