Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math.Random functions special and distributions only succeed for default arguments #2081

Closed
modelica-trac-importer opened this issue Jan 15, 2017 · 1 comment
Assignees
Labels
bug Critical/severe issue L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined
Milestone

Comments

@modelica-trac-importer
Copy link

Reported by beutlich on 17 Oct 2016 19:26 UTC
If ModelicaTest.Math.Random.distributions is called with first input argument nPoints smaller than default value 1000, e.g., 100, then the assertions fail since the error value thresholds are only valid for the unmodified default values. Thus it is without use to have nPoints (and erfRange) as inputs arguments available.

Reproduction: ModelicaTest.Math.Random.distributions(nPoints=100)


Migrated-From: https://trac.modelica.org/Modelica/ticket/2081

@modelica-trac-importer modelica-trac-importer added bug Critical/severe issue L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined labels Jan 15, 2017
MartinOtter added a commit that referenced this issue Jan 31, 2018
@MartinOtter
Copy link
Member

The reason for the issues have been that an approximate derivative with a two-side difference quotient is used to check that the same result is obtained by using the analytic solution of the distributions functions. However, this approximate, numeric solution is only precise enough, if there are enough points and the derivative is not computed at a discontinuous border. Both issues have been fixed (the first one by requireing that nPoints >= 1000).

@beutlich beutlich added this to the MSL3.2.3 milestone Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined
Projects
None yet
Development

No branches or pull requests

3 participants