Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C_default not defined in Modelica.Media.Interfaces.PartialMedium #2121

Closed
modelica-trac-importer opened this issue Jan 15, 2017 · 3 comments
Closed

C_default not defined in Modelica.Media.Interfaces.PartialMedium #2121

modelica-trac-importer opened this issue Jan 15, 2017 · 3 comments
Assignees
@beutlich
Labels
enhancement New feature or enhancement L: Media Issue addresses Modelica.Media P: high High priority issue
Milestone
MSL3.2.3

Comments

@modelica-trac-importer
Copy link

Reported by rubenbaetens on 24 Nov 2016 09:41 UTC
Modelica.Media.Interfaces.PartialMedium defines T_default, h_default, X_default and p_default, but no C_default. It would be better to add C_default = fill(0, Medium.nC) to the MSL so that all is consistent. As such, users can use C_default as the default start value and the default concentration for Boundary_pT, and can reassign this value in the medium.

Migrated-From: https://trac.modelica.org/Modelica/ticket/2121
@modelica-trac-importer modelica-trac-importer added enhancement New feature or enhancement L: Media Issue addresses Modelica.Media P: high High priority issue labels Jan 15, 2017
@beutlich
Copy link
Member

beutlich commented Feb 7, 2017

Pointing to @rubenbaetens.

@beutlich beutlich added this to the MSL_next-MINOR-version milestone Feb 7, 2017
@beutlich
Copy link
Member

beutlich commented Apr 4, 2017

@hubertus65 Any feedback on this enhancement?

beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Oct 14, 2017
@beutlich
refs modelica#2121: Add missing C_default to PartialMedium
941e361
beutlich added a commit to beutlich/ModelicaStandardLibrary that referenced this issue Oct 14, 2017
@beutlich
refs modelica#2121: Utilize C_default
ba52d0a
@beutlich beutlich mentioned this issue Oct 14, 2017
Merged
@beutlich beutlich assigned beutlich and unassigned hubertus65 Oct 14, 2017
@beutlich
Copy link
Member

beutlich commented Oct 14, 2017 •
edited
Loading

@rubenbaetens @casella Since this is labeled Hacktoberfest and the library officers did not give any feedback I created #2364 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beutlich beutlich

Labels
enhancement New feature or enhancement L: Media Issue addresses Modelica.Media P: high High priority issue
Projects
None yet
Milestone
MSL3.2.3
Development

No branches or pull requests
3 participants
@beutlich @hubertus65 @modelica-trac-importer