Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illegal modifiers in Modelica.Electrical.Analog.Examples.HeatingNPN_OrGate #2268

Closed
HansOlsson opened this issue Jun 15, 2017 · 2 comments
Closed
Assignees
Labels
bug Critical/severe issue example Issue only addresses example(s) L: Electrical.Analog Issue addresses Modelica.Electrical.Analog P: high High priority issue
Milestone

Comments

@HansOlsson
Copy link
Contributor

The model Modelica.Electrical.Analog.Examples.HeatingNPN_OrGate modifies protected variables vbc, ibe, vt_t in T1 and T2; causing a warning.

The start-value modifiers added as part of #799 seem good, so I would assume that the variables should not be protected - I could not see when that was changed.

A check-log from Dymola says:
Warning: Modifier for protected component vbc. This is not legal Modelica.
File: Modelica/Electrical/Analog/Examples/HeatingNPN_OrGate.mo, line 107
Context: Modelica.Electrical.Analog.Examples.HeatingNPN_OrGate.T1.vbc
Original declaration of vbc:
File: Modelica/Electrical/Analog/Semiconductors.mo, line 1050
Context: Modelica.Electrical.Analog.Semiconductors.HeatingNPN.vbc
Warning: Modifier for protected component ibe. This is not legal Modelica.
File: Modelica/Electrical/Analog/Examples/HeatingNPN_OrGate.mo, line 107
Context: Modelica.Electrical.Analog.Examples.HeatingNPN_OrGate.T1.ibe
Original declaration of ibe:
File: Modelica/Electrical/Analog/Semiconductors.mo, line 1054
Context: Modelica.Electrical.Analog.Semiconductors.HeatingNPN.ibe
Warning: Modifier for protected component vt_t. This is not legal Modelica.
File: Modelica/Electrical/Analog/Examples/HeatingNPN_OrGate.mo, line 106
Context: Modelica.Electrical.Analog.Examples.HeatingNPN_OrGate.T1.vt_t
Original declaration of vt_t:
File: Modelica/Electrical/Analog/Semiconductors.mo, line 1062
Context: Modelica.Electrical.Analog.Semiconductors.HeatingNPN.vt_t
Warning: Modifier for protected component vbc. This is not legal Modelica.
File: Modelica/Electrical/Analog/Examples/HeatingNPN_OrGate.mo, line 127
Context: Modelica.Electrical.Analog.Examples.HeatingNPN_OrGate.T2.vbc
Original declaration of vbc:
File: Modelica/Electrical/Analog/Semiconductors.mo, line 1050
Context: Modelica.Electrical.Analog.Semiconductors.HeatingNPN.vbc
Warning: Modifier for protected component ibe. This is not legal Modelica.
File: Modelica/Electrical/Analog/Examples/HeatingNPN_OrGate.mo, line 127
Context: Modelica.Electrical.Analog.Examples.HeatingNPN_OrGate.T2.ibe
Original declaration of ibe:
File: Modelica/Electrical/Analog/Semiconductors.mo, line 1054
Context: Modelica.Electrical.Analog.Semiconductors.HeatingNPN.ibe
Warning: Modifier for protected component vt_t. This is not legal Modelica.
File: Modelica/Electrical/Analog/Examples/HeatingNPN_OrGate.mo, line 126
Context: Modelica.Electrical.Analog.Examples.HeatingNPN_OrGate.T2.vt_t
Original declaration of vt_t:
File: Modelica/Electrical/Analog/Semiconductors.mo, line 1062
Context: Modelica.Electrical.Analog.Semiconductors.HeatingNPN.vt_t

@HansOlsson HansOlsson added bug Critical/severe issue L: Electrical.Analog Issue addresses Modelica.Electrical.Analog P: high High priority issue labels Jun 15, 2017
@beutlich beutlich added this to the MSL_next-MINOR-version milestone Jun 15, 2017
@beutlich
Copy link
Member

beutlich commented Oct 5, 2017

ibe and vbc was modified by 3cffe10. vt_t was modified by 81ee9b7. All fine. But they were set to proteced recently by 24ced86, which should be reverted then.

@beutlich
Copy link
Member

beutlich commented Oct 5, 2017

Resolved by eafbcbd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Critical/severe issue example Issue only addresses example(s) L: Electrical.Analog Issue addresses Modelica.Electrical.Analog P: high High priority issue
Projects
None yet
Development

No branches or pull requests

4 participants