Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more examples to FundamentalWave libraries #2276

Closed
christiankral opened this issue Jul 7, 2017 · 11 comments
Closed

Add more examples to FundamentalWave libraries #2276

christiankral opened this issue Jul 7, 2017 · 11 comments
Assignees
@christiankral
Labels
enhancement New feature or enhancement example Issue only addresses example(s) L: Electrical.Machines Issue addresses Modelica.Electrical.Machines L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave L: Magnetic.QuasiStatic Issue addresses Modelica.Magnetic.QuasiStatic
Milestone
MSL3.2.3

Comments

@christiankral
Copy link
Contributor

The examples of Modelica.Electrical.Machines.Examples shall be adopted for

  • Modelica.Magnetic.FundamentalWave.Examples
  • Modelica.Magnetic.QuasiStatic.FundamentalWave
@christiankral christiankral added enhancement New feature or enhancement L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave L: Magnetic.QuasiStatic Issue addresses Modelica.Magnetic.QuasiStatic labels Jul 7, 2017
@christiankral christiankral added this to the MSL_next-MINOR-version milestone Jul 7, 2017
@christiankral christiankral self-assigned this Jul 7, 2017
christiankral added a commit that referenced this issue Jul 8, 2017
@christiankral
Added more examples to FundamentalWave libraries, see #2276
1b0d1d9
christiankral added a commit that referenced this issue Jul 8, 2017
@christiankral
Added more examples to FundamentalWave libraries, see #2276
db0c55c
christiankral added a commit that referenced this issue Jul 8, 2017
@christiankral
Fixed grounding issue of #2276
7d505a8
christiankral added a commit that referenced this issue Jul 8, 2017
@christiankral
Fixed grounding issue of #2276
a5ecbcc
christiankral added a commit that referenced this issue Jul 8, 2017
@christiankral
Fixed grounding issue of #2276
40d9375
@christiankral
Copy link
Contributor Author

Relevant examples are added.

@christiankral
Copy link
Contributor Author

Re-structuring examples on Diagram layer

@christiankral christiankral reopened this Sep 19, 2017
@christiankral
Copy link
Contributor Author

I am also unifying the documentation format and fix wrong documentation

@christiankral christiankral added the L: Electrical.Machines Issue addresses Modelica.Electrical.Machines label Sep 19, 2017
@christiankral
Copy link
Contributor Author

Somehow the function wrapAngle and the block WrapAngle disappeared, even though added by #2050. This broke some models; so I re-integrated the function and block and the machine models now work fine again.

christiankral added a commit that referenced this issue Sep 19, 2017
@christiankral
Re-integrated #2050 and updated documentationa and examples, see #2276
6db855f
christiankral added a commit that referenced this issue Sep 19, 2017
@christiankral
Improved documentation, see #2276
a34e782
@christiankral christiankral mentioned this issue Sep 19, 2017
Closed
@beutlich
Copy link
Member

Somehow the function wrapAngle and the block WrapAngle disappeared, even though added by #2050.

It never was added to maint/3.2.2 branch. Furthermore, I am not sure if it is worth to maintain this branch.

@christiankral
Copy link
Contributor Author

christiankral commented Sep 19, 2017 •
edited by beutlich
Loading

Turning quasi static FundamentalWave examples into real polyphase machine examples.

christiankral added a commit that referenced this issue Sep 19, 2017
@christiankral
Created true polyphase examples, see #2276
5ba74f4
@beutlich beutlich mentioned this issue Sep 19, 2017
Closed
@christiankral christiankral mentioned this issue Sep 20, 2017
Closed
christiankral added a commit that referenced this issue Sep 26, 2017
@christiankral
Added two more examples to demonstrate characteristic curves, see #2276
6a820ae
christiankral added a commit that referenced this issue Sep 26, 2017
@christiankral
Updated examples and release notes, see #2276
630b9e4
christiankral added a commit that referenced this issue Sep 26, 2017
@christiankral
Added two more examples to demonstrate characteristic curves, see #2276
c36655b
christiankral added a commit that referenced this issue Sep 26, 2017
@christiankral
Updated examples and release notes, see #2276
355adf5
christiankral added a commit that referenced this issue Sep 26, 2017
@christiankral
Created true polyphase examples, see #2276
cdd8ddb
@beutlich
Copy link
Member

beutlich commented Oct 9, 2017

Any chance to provide better start values or use homotopy?

christiankral added a commit that referenced this issue Oct 10, 2017
@christiankral
Fixed wrong documentation of nominal speed, #2276
a75db8e
christiankral added a commit that referenced this issue Oct 10, 2017
@christiankral
Fixed wrong documentation of nominal speed, #2276
6707f47
christiankral added a commit that referenced this issue Oct 10, 2017
@christiankral
Added some additional variables to compare, #2276
819633f
christiankral added a commit that referenced this issue Oct 10, 2017
@christiankral
Added some additional variables to compare, #2276
4e3cff8
christiankral added a commit that referenced this issue Oct 15, 2017
@christiankral
Changed order of examples and added some more variable, see #2276
8f32ff7
christiankral added a commit that referenced this issue Oct 15, 2017
@christiankral
Changed order of examples and added some more variable, see #2276
5c8112c
christiankral added a commit that referenced this issue Oct 15, 2017
@christiankral
Fixed wrong model instance name, see #2276
9619418
christiankral added a commit that referenced this issue Oct 15, 2017
@christiankral
Fixed wrong model instance name, see #2276
c72477c
christiankral added a commit that referenced this issue Oct 21, 2017
@christiankral
Unified icon appearance and improved structure, see #2276
ea98153
christiankral added a commit that referenced this issue Oct 21, 2017
@christiankral
Unified icon appearance and improved structure, see #2276
09e064d
christiankral added a commit that referenced this issue Oct 28, 2017
@christiankral
Added some more alias variables for the rotor displacement angles, see …
0e15dfb 
…#2276
christiankral added a commit that referenced this issue Oct 28, 2017
@christiankral
Added some more alias variables for the rotor displacement angles, see …
3db07b9 
…#2276
christiankral added a commit that referenced this issue Nov 6, 2017
@christiankral
Added new model #2276, fixed #2386
ed5a366
christiankral added a commit that referenced this issue Nov 6, 2017
@christiankral
Added new model #2276, fixed #2386
18edf45
christiankral added a commit that referenced this issue Nov 6, 2017
@christiankral
Updated doc string, #2276
412255f
christiankral added a commit that referenced this issue Nov 6, 2017
@christiankral
Updated doc string, #2276
a666293
christiankral added a commit that referenced this issue Nov 6, 2017
@christiankral
Updated doc string, #2276.
2a7adea
christiankral added a commit that referenced this issue Nov 6, 2017
@christiankral
Updated doc string, #2276.
99a3ff7
christiankral added a commit that referenced this issue Jan 3, 2018
@christiankral
Updated documentation of new machine example, see #2276
307a2b2
christiankral added a commit that referenced this issue Jan 3, 2018
@christiankral
Updated documentation of new machine example, see #2276
376cca0
christiankral added a commit that referenced this issue Feb 5, 2018
@christiankral
Removed transient SMR_Inverter from quasi static examples, see #2276
7f815ab
christiankral added a commit that referenced this issue Feb 5, 2018
@christiankral
Removed transient SMR_Inverter from quasi static examples, see #2276
6c44462
@christiankral
Copy link
Contributor Author

christiankral commented Feb 5, 2018 •
edited
Loading

Removed SMR_Inverter example in 7f815ab and 6c44462 since it does not make sense to demonstrate quasi static behavior of a transient example case. This is a backwards compatible change, since the models are not included in the official release of MSL 3.2.2.

@beutlich beutlich changed the title Add more examples to FundamentalWave libraries Add more examples to FundamentalWave libraries Apr 10, 2018
@christiankral
Copy link
Contributor Author

Removed obsolete model in fa63e56 and d12767f. Implementation of new models is now completed.

christiankral added a commit that referenced this issue May 15, 2018
@christiankral
Removing obsolete simulation model introduced by #2276
82b6ca5 
Fix of spelling error
@beutlich beutlich added the example Issue only addresses example(s) label May 28, 2018
@beutlich beutlich mentioned this issue Dec 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christiankral christiankral

Labels
enhancement New feature or enhancement example Issue only addresses example(s) L: Electrical.Machines Issue addresses Modelica.Electrical.Machines L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave L: Magnetic.QuasiStatic Issue addresses Modelica.Magnetic.QuasiStatic
Projects
None yet
Milestone
MSL3.2.3
Development

No branches or pull requests
2 participants
@christiankral @beutlich